Unblock CI: Ignore deprecation and skip a test #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblock CI until these can be migrated. Recompile host.dart
PR Health |
No user facing changes.
|
Or, you know, we could fix these! 😄 |
|
At least a TODO and an open issue to migrate? |
natebosch
changed the title
jakemac53
approved these changes
Jan 15, 2025
I don't see value in a TODO when a grep for |
|
Holding back the recompile since that is triggering some other CI bug |
See #2288 These seem to be failing to load.
natebosch
changed the title
|
hmm, I didn't know that we don't support making configuration specific to an OS when it's running on the browser... I thought that was possible but when we evaluate the test/pkgs/test_api/lib/src/backend/suite_platform.dart Lines 41 to 43 in f364fc8 |
|
linux firefox tests are also not working, we can skip these entirely on firefox for now to get unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblock CI until these can be migrated and fixed.